This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s for all xre components
…ize entities in entityTree that do not have an object3d in the scene already
HexaField
suggested changes
Mar 28, 2022
HexaField
approved these changes
Mar 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The editor "Import Scene" and "Export Scene" buttons now handle glTF equivalents of scene.json files.
The GLTFExporter class has been replaced.
disposeScene now cleans up the ECS system.
Partially implemented JSON schemas for all scene components in glTF extension form. Also added schemas of glTF format for eventual use in validation.
Checklist
npm run check
npm run lint
npm run test:packages
npm run build-client
References
#5518
QA Steps
git checkout pr_branch_name
npm install
npm run dev-reinit
npm run dev
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.
Reviewers
Reviewers for this PR