Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Reimplemented glTF Import/Export #5571

Merged
merged 38 commits into from
Mar 30, 2022
Merged

Reimplemented glTF Import/Export #5571

merged 38 commits into from
Mar 30, 2022

Conversation

dinomut1
Copy link
Member

@dinomut1 dinomut1 commented Mar 28, 2022

Summary

The editor "Import Scene" and "Export Scene" buttons now handle glTF equivalents of scene.json files.
The GLTFExporter class has been replaced.
disposeScene now cleans up the ECS system.
Partially implemented JSON schemas for all scene components in glTF extension form. Also added schemas of glTF format for eventual use in validation.

Checklist

  • Pre-push checks pass npm run check
    • Linter passing via npm run lint
    • Unit & Integration tests passing via npm run test:packages
    • Docker build process passing via npm run build-client
  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

References

#5518

QA Steps

  1. git checkout pr_branch_name
  2. npm install
  3. npm run dev-reinit
  4. npm run dev

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Reviewers

Reviewers for this PR

…ize entities in entityTree that do not have an object3d in the scene already
packages/engine/src/assets/classes/AssetLoader.ts Outdated Show resolved Hide resolved
packages/engine/src/ecs/classes/World.ts Outdated Show resolved Hide resolved
@dinomut1 dinomut1 requested a review from HexaField March 29, 2022 23:05
@dinomut1 dinomut1 merged commit c120bac into dev Mar 30, 2022
@dinomut1 dinomut1 deleted the scene-to-gltf branch March 30, 2022 04:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants