Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Replace FXAA with SMAA #5594

Merged
merged 3 commits into from
Mar 31, 2022
Merged

Replace FXAA with SMAA #5594

merged 3 commits into from
Mar 31, 2022

Conversation

HexaField
Copy link
Member

@HexaField HexaField commented Mar 31, 2022

Summary

  • replaces broken FXAA with SMAA
  • adds verification for post processing schema data

Checklist

  • Pre-push checks pass npm run check
    • Linter passing via npm run lint
    • Unit & Integration tests passing via npm run test:packages
    • Docker build process passing via npm run build-client
  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

References

closes #5568

QA Steps

  1. git checkout pr_branch_name
  2. npm install
  3. npm run dev-reinit
  4. npm run dev

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Reviewers

Reviewers for this PR

@HexaField HexaField merged commit 41727c5 into dev Mar 31, 2022
@HexaField HexaField deleted the replace-fxaa-smaa branch March 31, 2022 23:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FXAA is broken
2 participants