This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 0
File browser refactor and refinements #5595
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HexaField
suggested changes
Apr 1, 2022
packages/server-core/src/media/storageprovider/local.storage.ts
Outdated
Show resolved
Hide resolved
HexaField
suggested changes
Apr 5, 2022
packages/editor/src/components/assets/FileBrowserContentPanel.tsx
Outdated
Show resolved
Hide resolved
packages/server-core/src/media/file-browser/file-browser.test.ts
Outdated
Show resolved
Hide resolved
HexaField
suggested changes
Apr 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uploading a file to the root of a project seems to add it as both a file and a folder.
Trying to drag any asset from the file browser to a text properties field copies incorrectly by appending undefined
at the end of the path for example: /image.pngundefined
@HexaField, Not able to reproduce below one, can you provide more steps?
|
…ditor-UI-bug-fix
See below: |
HexaField
approved these changes
Apr 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added support to apply changes to
package/projects
for all thefile-browser
apisAlso worked on loading models issue when loading from file system.
Fixed unloading of scene when it is deleted
Checklist
npm run check
npm run lint
npm run test:packages
npm run build-client
References
QA Steps
git checkout pr_branch_name
npm install
npm run dev-reinit
npm run dev
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.
Reviewers
@HexaField @zulqarnainhanif