Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

File browser refactor and refinements #5595

Merged
merged 24 commits into from
Apr 11, 2022
Merged

File browser refactor and refinements #5595

merged 24 commits into from
Apr 11, 2022

Conversation

NPatel10
Copy link
Contributor

@NPatel10 NPatel10 commented Mar 31, 2022

Summary

Added support to apply changes to package/projects for all the file-browser apis
Also worked on loading models issue when loading from file system.
Fixed unloading of scene when it is deleted

Checklist

  • Pre-push checks pass npm run check
    • Linter passing via npm run lint
    • Unit & Integration tests passing via npm run test:packages
    • Docker build process passing via npm run build-client
  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

References

QA Steps

  1. git checkout pr_branch_name
  2. npm install
  3. npm run dev-reinit
  4. npm run dev

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Reviewers

@HexaField @zulqarnainhanif

@NPatel10 NPatel10 linked an issue Mar 31, 2022 that may be closed by this pull request
@NPatel10 NPatel10 linked an issue Mar 31, 2022 that may be closed by this pull request
@zulqarnainhanif
Copy link
Contributor

zulqarnainhanif commented Mar 31, 2022

getting below error in terminal on deleting folder through localhost

Screenshot 2022-03-31 at 10 07 12 PM

@NPatel10 NPatel10 linked an issue Apr 5, 2022 that may be closed by this pull request
Copy link
Member

@HexaField HexaField left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uploading a file to the root of a project seems to add it as both a file and a folder.

Trying to drag any asset from the file browser to a text properties field copies incorrectly by appending undefined at the end of the path for example: /image.pngundefined

@NPatel10
Copy link
Contributor Author

NPatel10 commented Apr 8, 2022

@HexaField, Not able to reproduce below one, can you provide more steps?

Uploading a file to the root of a project seems to add it as both a file and a folder.

@HexaField
Copy link
Member

HexaField commented Apr 9, 2022

@HexaField, Not able to reproduce below one, can you provide more steps?

Uploading a file to the root of a project seems to add it as both a file and a folder.

@NPatel10

  1. drag a file into the file browser panel
  2. once it finishes uploading, it shows as both a folder and a file with the same name

See below: goblin.glb

Screenshot from 2022-04-09 12-14-32

@NPatel10
Copy link
Contributor Author

Uploading a file to the root of a project seems to add it as both a file and a folder.

Can we create a separate issue for this bug, Because I am not able to regenerate it in my system. Maybe an OS issue?

Screenshot 2022-03-26 121703

@HexaField HexaField merged commit 39fdaf0 into dev Apr 11, 2022
@HexaField HexaField deleted the Editor-UI-bug-fix branch April 11, 2022 09:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants