Feathers Avatar Upload Works

[HexaField]

Summary

• generic feathers XHR uploader
• location avatar upload works
• admin avatar upload/view uses location modal
• css works both in locaiton and admin
• readyplayerme uses new upload & works properly

refactors the large file upload XHR function to be service agnostic, and fixes the problems with avatar uploading which was due to not properly waiting for the request to complete.

Checklist

• Pre-push checks pass npm run check
  • Linter passing via npm run lint
  • Unit & Integration tests passing via npm run test:packages
  • Docker build process passing via npm run build-client
• If this PR is still a WIP, convert to a draft
• When this PR is ready, mark it as "Ready for review"
• Changes have been manually QA'd
• Changes reviewed by at least 2 approved reviewers

References

closes #5577

QA Steps

1. git checkout pr_branch_name
2. npm install
3. npm run dev-reinit
4. npm run dev

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Reviewers

Reviewers for this PR

[zulqarnainhanif]

@HexaField Please look into the client-core/src/admin/components/Avatars/AvatarCreate.tsx file as well it uses the similar code that might need fixing. Both Avatar components can use helper functions a lot/can be cleaned up.

[zulqarnainhanif]

@HexaField can you help with the below view and thumbnail created against the avatar in admin panel as well.

[zulqarnainhanif]

newly added avatar from admin panel have no preview thumbnail.

[HexaField]

@zulqarnainhanif hmm yes, the admin panel will need to initialize the engine for it to be able to use the location upload modal rather than the admin upload modal

[barankyle]

With local storage, uploaded avatars' filenames are coming out as e.g. avatars/public/1649701290717CyberbotSilver.glb. Is the number supposed to be a sub-directory with the .glb inside that sub-directory?

While the uploaded file has an extension of .glb, its file type is 'image'. This might be why, when I try to change to them in a scene, nothing gets rendered.

Is the uploader supposed to create a default thumbnail and/or have some way to upload a thumbnail?

I tried uploading from this URL: https://resources-dev.theoverlay.io/avatars/public/Razer3.glb and the resulting file had the name 1649701869997undefined . When I opened the uploader again and pasted the same source URL in, there's an error about the URL being invalid.

[zulqarnainhanif]

@HexaField the view for pre-uploaded avatars shows up empty in admin panel.

[zulqarnainhanif]

thumbnail generation looks off

[HexaField]

@HexaField the view for pre-uploaded avatars shows up empty in admin panel.

this seems to be because an avatar is uploaded with no name, which shouldnt happen, it appears this is from something else

[HexaField]

thumbnail generation looks off

this is because the avatar was not positioned when the upload button was pressed. this funcitonality is good enough for now, we can improve this workflow when we implement the character creator