This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Engine initialization now happens before any routes are loaded, meaning the engine is always loaded and running for all routes, which helps keep consistency and not duplicating code for each route.
This PR adds two offline modes:
/offline/<projectName>/<sceneName>
/location/<locationName>?offline=true
Improves how the location name provided from the URL is handled, rather than passing it around (sometimes incorrectly) it is put into client state
Also refactors the use of AuthSevice.doAutoLogin which was being called in many places unnecessarily. Also removes the
allowGuest
which is redundant with how routes are provided from the API server.Refactors the admin panel to not have intermediary 'pages' files that only served other components, now lazy loading those components directly.
Checklist
npm run check
npm run lint
npm run test:packages
npm run build-client
References
References to pertaining issue(s)
QA Steps
git checkout pr_branch_name
npm install
npm run dev-reinit
npm run dev
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.
Reviewers
Reviewers for this PR