Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Csm issue fix #5684

Merged
merged 5 commits into from
Apr 11, 2022
Merged

Csm issue fix #5684

merged 5 commits into from
Apr 11, 2022

Conversation

NPatel10
Copy link
Contributor

@NPatel10 NPatel10 commented Apr 8, 2022

Summary

Worked on following issues

  • Amended shader to match with https://github.com/mrdoob/three.js/pull/23631/files pr on Three js library
  • Added useInCSM option in directional light. This will allow user to select a directional light to be used in CSM. Currently CSM only support one directional light. Therefore selecting this option in one directional light will automatically deselect the same option in all other directional lights.
  • When CSM will be enabled castShadow property will be set to false for all the directional lights. And when CSM will be disabled the same property will be set to its previous value. This is because current shader supports only one directional light for casting shadow if CSM is enabled.
  • If useInCSM option set to true then changing the rotation of that light will affect the rotation of the lights used in CSM.

Checklist

  • Pre-push checks pass npm run check
    • Linter passing via npm run lint
    • Unit & Integration tests passing via npm run test:packages
    • Docker build process passing via npm run build-client
  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

References

QA Steps

  1. git checkout pr_branch_name
  2. npm install
  3. npm run dev-reinit
  4. npm run dev

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Reviewers

@HexaField

@NPatel10 NPatel10 marked this pull request as ready for review April 11, 2022 04:25

assert(!hasComponent(entity, Object3DComponent))
console.debug(light.castShadow)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log

@HexaField HexaField merged commit 66521dd into dev Apr 11, 2022
@HexaField HexaField deleted the CSM-Issue-fix branch April 11, 2022 10:25
@NPatel10 NPatel10 linked an issue Apr 11, 2022 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve CSM
2 participants