Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Fixed a couple of bugs with the PIP user video window. #5719

Merged
merged 2 commits into from
Apr 13, 2022

Conversation

barankyle
Copy link
Member

@barankyle barankyle commented Apr 12, 2022

Summary

Controls were being z-indexed behind the other elements and shrunk on hover on large screens,
which didn't have any purpose; removed hover/focus styling on large screens.

Setting window position via right but then always changing the left was causing problems with snap
to left/right logic; changed initial position to also be set via left.

Checklist

  • Pre-push checks pass npm run check
    • Linter passing via npm run lint
    • Unit & Integration tests passing via npm run test:packages
    • Docker build process passing via npm run build-client
  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

References

References to pertaining issue(s)

QA Steps

  1. git checkout pr_branch_name
  2. npm install
  3. npm run dev-reinit
  4. npm run dev

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Reviewers

Reviewers for this PR

Controls were being z-indexed behind the other elements and shrunk on hover on large screens,
which didn't have any purpose; removed hover/focus styling on large screens.

Setting window position via right but then always changing the left was causing problems with snap
to left/right logic; changed initial position to also be set via left.
@HexaField HexaField merged commit 5e40871 into dev Apr 13, 2022
@HexaField HexaField deleted the video-window-bugfixes branch April 13, 2022 04:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants