Refactor code #5729

zulqarnainhanif · 2022-04-12T19:15:59Z

Summary

Removing extra styling
Fix naming of scss files
Remove extra dispatch imports / hooks

CI/CD checks pass npm run check
- Linter passing via npm run lint
- Typescript passing via npm run check-errors
- Unit & Integration tests passing via npm run test
- Docker build process passing via npm run build-client
If this PR is still a WIP, convert to a draft
When this PR is ready, mark it as "Ready for review"
Changes have been manually QA'd
Changes reviewed by at least 2 approved reviewers

zulqarnainhanif added 2 commits April 13, 2022 00:09

remove extra varaible and imports in scss

6eca9ba

remove extra import from mixins scss file

bdd0876

zulqarnainhanif requested a review from HexaField April 12, 2022 19:15

zulqarnainhanif added 5 commits April 13, 2022 20:06

resolve merge conflict

38ceec9

fix naming conventions in client-core

9cdb51c

fix naming conventions in client-core components

3690de3

fix naming conventions in client-core components

10390ad

fix pipeline failing

123e290

zulqarnainhanif requested a review from speigg April 13, 2022 15:56

zulqarnainhanif added 3 commits April 13, 2022 21:03

file name fix

b829574

fix file name for common scss file

1d4e39a

remove unnecessary dispatch imports

6309530

zulqarnainhanif marked this pull request as ready for review April 13, 2022 16:27

speigg approved these changes Apr 13, 2022

View reviewed changes

speigg merged commit 671326f into dev Apr 13, 2022

HexaField deleted the refactor-code branch April 19, 2022 01:13