This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 0
Improve Engine Timer accuracy and World time sync #5772
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cb39fa3.
Improve tick sync accuracy
I don't know why this test is failing
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Engine Timer accuracy has been improved by calculating
elapsedTime
based on high precision starting time, rather than accumulation of deltas. Max delta logic has been moved into world execution.World time sync has been improved by coordinating the world's
elapsedTime
across the network, including correction for latency using each computer's local clock time. Elapsed time is synced immediately when the world is joined. NetworkWorldAction.timeSync() has also been added to ensure that clients stay in sync over longer periods of time.Checklist
npm run check
npm run lint
npm run check-errors
npm run test
npm run build-client
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.
Reviewers
Reviewers for this PR