Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Use Custom Theme from DB in Client #5852

Merged
merged 45 commits into from
May 9, 2022
Merged

Use Custom Theme from DB in Client #5852

merged 45 commits into from
May 9, 2022

Conversation

zulqarnainhanif
Copy link
Contributor

@zulqarnainhanif zulqarnainhanif commented Apr 25, 2022

Summary

  • Replace old variable with custom theme variables throughout app
  • On saving new theme change the theme on run-time
  • Fix Sketch Color Picker when selected near screen end
  • Refactor ClientTheme.jsx Code
  • Add Stuff in Demo Area in Client Theme maker
    • Table (used in admin panels)
    • Dropdown hover Background
    • Popup Background
    • Editor dock panel Background

Checklist

  • CI/CD checks pass npm run check
    • Linter passing via npm run lint
    • Typescript passing via npm run check-errors
    • Unit & Integration tests passing via npm run test
    • Docker build process passing via npm run build-client
  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

Reviewers

@HexaField @speigg

@zulqarnainhanif zulqarnainhanif marked this pull request as ready for review May 6, 2022 21:34
@speigg
Copy link
Member

speigg commented May 6, 2022

Something wrong with header colors in the Theme "Demo Area", but otherwise looks great!
image

@speigg
Copy link
Member

speigg commented May 6, 2022

A few other minor suggestions:

  • Can we rename "Demo Area" to Theme Playground"
  • A button to reset to the default theme

@zulqarnainhanif
Copy link
Contributor Author

A few other minor suggestions:

  • Can we rename "Demo Area" to Theme Playground"
  • A button to reset to the default theme

have added both the changes @speigg

@HexaField HexaField merged commit 6b26672 into dev May 9, 2022
@HexaField HexaField deleted the CustomThemeInClient branch May 9, 2022 22:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants