Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Fix Local Build & Improve Env Var Handling #5859

Merged
merged 2 commits into from
Apr 26, 2022
Merged

Fix Local Build & Improve Env Var Handling #5859

merged 2 commits into from
Apr 26, 2022

Conversation

HexaField
Copy link
Member

Summary

npm run local has not been working since the last dep update and recent changes, it now works again, and a few things have been simplified

References

closes #insert number here

Checklist

  • CI/CD checks pass npm run check
    • Linter passing via npm run lint
    • Typescript passing via npm run check-errors
    • Unit & Integration tests passing via npm run test
    • Docker build process passing via npm run build-client
  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Reviewers

Reviewers for this PR

Copy link
Member

@hanzlamateen hanzlamateen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine on minikube

@HexaField HexaField merged commit 7730078 into dev Apr 26, 2022
@HexaField HexaField deleted the local-build-fix branch April 26, 2022 09:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants