Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Instancify Engine Object #5860

Merged
merged 8 commits into from
Apr 27, 2022
Merged

Instancify Engine Object #5860

merged 8 commits into from
Apr 27, 2022

Conversation

HexaField
Copy link
Member

@HexaField HexaField commented Apr 26, 2022

Summary

all usage of Engine. is now Engine.instance.

References

#5834

Checklist

  • CI/CD checks pass npm run check
    • Linter passing via npm run lint
    • Typescript passing via npm run check-errors
    • Unit & Integration tests passing via npm run test
    • Docker build process passing via npm run build-client
  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Reviewers

Reviewers for this PR

@HexaField HexaField marked this pull request as draft April 26, 2022 08:03
Copy link
Contributor

@NPatel10 NPatel10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only concern I have is whether it is going to have any impact on performance. Since property access chain became longer.

@HexaField HexaField marked this pull request as ready for review April 26, 2022 11:17
@HexaField HexaField merged commit ca30826 into dev Apr 27, 2022
@HexaField HexaField deleted the engine-instance branch April 27, 2022 03:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants