Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Jump Animation Update #5864

Merged
merged 6 commits into from
Apr 28, 2022
Merged

Jump Animation Update #5864

merged 6 commits into from
Apr 28, 2022

Conversation

mohsenheydari
Copy link
Contributor

Summary

  • Divides the jump state into 3 states: Jump Start, Fall, Jump End
  • Adds the following animation tracks to Animations.glb : Jump Up, Fall Idle, Jump Down
  • Adds isInAir property to AvatarControllerComponent

References

closes #5744

Checklist

  • CI/CD checks pass npm run check
    • Linter passing via npm run lint
    • Typescript passing via npm run check-errors
    • Unit & Integration tests passing via npm run test
    • Docker build process passing via npm run build-client
  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Reviewers

Reviewers for this PR
@HexaField

@mohsenheydari mohsenheydari changed the title Fall Animation Update Jump Animation Update Apr 26, 2022
Copy link
Member

@HexaField HexaField left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good improvement so far, a few things I am noticing:

  • It looks a bit strange still while landing if avatar is still moving, maybe we need to blend a bit faster and more aggressively, or detect ahead of time before the avatar lands to transition to the landing animation, so we can more quickly transition to walking/running

  • Landing on an angled surface does not trigger the fall animation, so the avatar never transitions to movement

Updates jump down blend value
@HexaField HexaField merged commit b4a3336 into dev Apr 28, 2022
@HexaField HexaField deleted the jump_animation branch April 28, 2022 08:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

player jumping is awkward
2 participants