Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Set isLoggedIn after LOADED_USER_DATA #5976

Merged
merged 1 commit into from
May 5, 2022
Merged

Set isLoggedIn after LOADED_USER_DATA #5976

merged 1 commit into from
May 5, 2022

Conversation

speigg
Copy link
Member

@speigg speigg commented May 5, 2022

Summary

Logged in state should be dependent on user data being loaded. Before this, authState.isLoggedIn could be true while authState.user had no data, while calling retrieveLocationByName. Now this is not possible.

References

closes #insert number here

Checklist

  • CI/CD checks pass npm run check
    • Linter passing via npm run lint
    • Typescript passing via npm run check-errors
    • Unit & Integration tests passing via npm run test
    • Docker build process passing via npm run build-client
  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Reviewers

Reviewers for this PR

@@ -3,7 +3,6 @@
"version": "0.5.3",
"main": "index.ts",
"description": "State Management for XREngine",
"private": true,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated, but I had to publish this package to fix install process on some machines

@speigg speigg merged commit 8953db6 into dev May 5, 2022
@HexaField HexaField deleted the loggedin-state branch May 10, 2022 07:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants