Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Storage Provider no longer in Global Scope #6055

Merged
merged 2 commits into from
May 13, 2022
Merged

Conversation

HexaField
Copy link
Member

Summary

The storage provider is being created in global scope, which makes it hard to override in tests. This also allows us to have better clarity over which storage provider will be in use when we move to support multiple storage providers.

References

closes #insert number here

Checklist

  • CI/CD checks pass npm run check
    • Linter passing via npm run lint
    • Typescript passing via npm run check-errors
    • Unit & Integration tests passing via npm run test
    • Docker build process passing via npm run build-client
  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Reviewers

Reviewers for this PR

@HexaField HexaField requested a review from barankyle May 13, 2022 03:23
@HexaField HexaField requested a review from speigg May 13, 2022 03:54
@HexaField HexaField merged commit 58b659b into dev May 13, 2022
@HexaField HexaField deleted the storage-provider-scope branch May 13, 2022 04:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant