This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
scene service now handles cubemap in various scene operations #6142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barankyle
approved these changes
May 18, 2022
Griffisaurus
approved these changes
May 18, 2022
FabriceIRANKUNDA
pushed a commit
that referenced
this pull request
May 20, 2022
* scene service now handles cubemap in various scene operations * format
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A summary of changes being made in this PR
References
closes #insert number here
Checklist
npm run checknpm run lintnpm run check-errorsnpm run testnpm run build-clientQA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.
Reviewers
Reviewers for this PR