Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Animation system functional refactor #6160

Merged
merged 15 commits into from
May 26, 2022

Conversation

mohsenheydari
Copy link
Contributor

@mohsenheydari mohsenheydari commented May 20, 2022

Summary

  • Animation system functional refactor
  • Adds animation system unit tests

References

closes #5943

Checklist

  • CI/CD checks pass npm run check
    • Linter passing via npm run lint
    • Typescript passing via npm run check-errors
    • Unit & Integration tests passing via npm run test
    • Docker build process passing via npm run build-client
  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Reviewers

@HexaField

@mohsenheydari mohsenheydari marked this pull request as ready for review May 23, 2022 13:04
@mohsenheydari mohsenheydari requested a review from speigg May 23, 2022 13:05
Copy link
Member

@HexaField HexaField left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we can make the implementation for all these rules more elegant by doing something like

export function booleanTransitionRule(object: any, property: string, negate: boolean = false) {
  return () => {
    const value = object[property]
    return negate ? !value : value
  }
}

in which case each rule is simply a function that can be run, similar to how it is implemented before this PR, but allows for more composability

@HexaField HexaField merged commit 88e7811 into dev May 26, 2022
@HexaField HexaField deleted the Animation-System-Functional-Refactor branch May 26, 2022 23:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit tests & functional refactor for animations
2 participants