This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Fixed some bugs in WebRTCFunctions.ts and project retrieval #6167
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Despite checking that transport exists, apparently it can be undefined/null by the time
router checks are performed. This could lead to the whole media server crashing because it
was trying to read (null).internal. Added conditional check in each occurrence to prevent that.
Made handleSendTrack check if there's already a producer with the exact same appData, and close it
if so.
Added much higher default pagination on calls to project.find. We're normally using the results as
if they're the entirety of the projects in the database, so the default of 10 could easily cause
projects to not be found by that call.
References
closes #insert number here
Checklist
npm run check
npm run lint
npm run check-errors
npm run test
npm run build-client
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.
Reviewers
Reviewers for this PR