Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Fixed some bugs in WebRTCFunctions.ts and project retrieval #6167

Merged
merged 2 commits into from
May 21, 2022

Conversation

barankyle
Copy link
Member

@barankyle barankyle commented May 21, 2022

Summary

Despite checking that transport exists, apparently it can be undefined/null by the time
router checks are performed. This could lead to the whole media server crashing because it
was trying to read (null).internal. Added conditional check in each occurrence to prevent that.

Made handleSendTrack check if there's already a producer with the exact same appData, and close it
if so.

Added much higher default pagination on calls to project.find. We're normally using the results as
if they're the entirety of the projects in the database, so the default of 10 could easily cause
projects to not be found by that call.

References

closes #insert number here

Checklist

  • CI/CD checks pass npm run check
    • Linter passing via npm run lint
    • Typescript passing via npm run check-errors
    • Unit & Integration tests passing via npm run test
    • Docker build process passing via npm run build-client
  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Reviewers

Reviewers for this PR

Despite checking that transport exists, apparently it can be undefined/null by the time
router checks are performed. This could lead to the whole media server crashing because it
was trying to read (null).internal. Added conditional check in each occurrence to prevent that.

Made handleSendTrack check if there's already a producer with the exact same appData, and close it
if so.

Added much higher default pagination on calls to project.find. We're normally using the results as
if they're the entirety of the projects in the database, so the default of 10 could easily cause
projects to not be found by that call.
@HexaField
Copy link
Member

Can we instead selectively disable pagination in certain feathers calls? I believe we are doing this elsewhere in the codebase already.

@speigg speigg merged commit c22149e into dev May 21, 2022
@HexaField HexaField deleted the transport-and-project-bugfixes branch May 21, 2022 22:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants