Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Changes to use common notification service across the app #6234

Merged
merged 3 commits into from
May 27, 2022

Conversation

hanzlamateen
Copy link
Member

Summary

These changes introduces and easy to use service to use accross frontend to show toast/notifications based on notistack. Now anywhere in the code just make use of below snippet to show notifications.

NotificationService.dispatchNotify('Message alert here', { variant: 'default' })
// variant can be success, error, warning, etc

References

#6215

Checklist

  • CI/CD checks pass npm run check
    • Linter passing via npm run lint
    • Typescript passing via npm run check-errors
    • Unit & Integration tests passing via npm run test
    • Docker build process passing via npm run build-client
  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Reviewers

Reviewers for this PR

@speigg speigg merged commit e0e5e17 into dev May 27, 2022
@hanzlamateen hanzlamateen deleted the notification-fixes branch May 27, 2022 16:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants