Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Nayan small bug fixes #6367

Merged
merged 21 commits into from
Jun 11, 2022
Merged

Nayan small bug fixes #6367

merged 21 commits into from
Jun 11, 2022

Conversation

NPatel10
Copy link
Contributor

@NPatel10 NPatel10 commented Jun 7, 2022

Summary

Worked on following issues,

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

@HexaField @speigg

Copy link
Member

@HexaField HexaField left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not following the style guide set out in this PR for hyperflux actions, state & receptors. please ensure it is following the exact format show in the linked PR

@HexaField
Copy link
Member

seeing an error immediately upon loading Screenshot from 2022-06-08 21-31-26

@HexaField
Copy link
Member

HexaField commented Jun 8, 2022

  • changing renderer lighting mode (unlit, lit, shadows etc) requires a reload to take effect

@HexaField
Copy link
Member

  • changing scenes will sometimes fail

@HexaField
Copy link
Member

selecting more than one object crashes
Screenshot from 2022-06-08 21-38-12

@HexaField
Copy link
Member

HexaField commented Jun 8, 2022

various errors and crash when quit button is clicked. main projects page doesnt load at all.

Screenshot from 2022-06-08 21-40-13

@NPatel10
Copy link
Contributor Author

NPatel10 commented Jun 9, 2022

various errors and crash when quit button is clicked. main projects page doesnt load at all.

Not able to recreate this issue.

@NPatel10
Copy link
Contributor Author

NPatel10 commented Jun 9, 2022

selecting more than one object crashes

Not able to recreate

@NPatel10
Copy link
Contributor Author

NPatel10 commented Jun 9, 2022

  • changing scenes will sometimes fail

Not able to recreate. If you can provide screen shot of the issue maybe I can identify the cause.

@NPatel10
Copy link
Contributor Author

NPatel10 commented Jun 9, 2022

There is one general observation on getComponent function. This component returns null sometimes and there is no type check for this. This is the main reason for above errors and errors which is not identified yet. What should we do about this issue? let me know your thoughts.

@HexaField HexaField merged commit 498495d into dev Jun 11, 2022
@HexaField HexaField deleted the Nayan---small-bug-fixes branch June 11, 2022 01:33
@NPatel10 NPatel10 linked an issue Jun 11, 2022 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: NPC animations not working in shopping district
2 participants