This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Fixed bugs in instance channel fetching and display. #6394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes, the client recognizes a connection to an instance server has been made before the initial 'joined' message has been created, and so when the instance channel is fetched, there are no messages. Added a check for number of messages that triggers a refetch in 500 ms until there are messages to display. Added some checks to InstanceChat/index.tsx that messages[index -1] exists before trying to call isLeftOrJoinText on that; the above bug brought to light a bug here where that call would throw an error since there was no prior message to call on.
barankyle
force-pushed
the
channel-message-fixes
branch
from
cb335cd
to
f0955d3
Compare
HexaField
approved these changes
Jun 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sometimes, the client recognizes a connection to an instance server has been made
before the initial 'joined' message has been created, and so when the instance channel
is fetched, there are no messages. Added a check for number of messages that triggers
a refetch in 500 ms until there are messages to display.
Added some checks to InstanceChat/index.tsx that messages[index -1] exists before trying
to call isLeftOrJoinText on that; the above bug brought to light a bug here where that
call would throw an error since there was no prior message to call on.
References
closes #insert number here
Checklist
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.