-
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Autofilling of text boxes in things like user name, group name, etc. is hard to read since the text color is white and the autofill background is near-white. On current dev, the autofill text color is black, which is much easier to see. You can test this by going to e.g. Create User, then clicking on the name field and selecting a value from one of the autofill options.
This appears to predate this issue, but if you could clean it up a bit that would be great: The avatar creation drawer has buttons and selectors that are very widely spaced and/or just wide. The 'Use URL/Upload Files' selector is on the far left, while the 'Avatar/Thumbnail' selectors are on the far right. I'm not sure if this would look better centered, or all on the left or right, but they should be together. The Upload button and Avatar Name field are also basically the full width of the drawer, which I don't think looks great - I think they'd look better as maybe 200px max wide and centered, or something around that (max-width: 100% if the drawer is less than 200px wide).
In my recent changes I removed autocomplete functionality from dialogs and as part this point in this PR, the autocomplete functionality is not there is create user drawer rahter its only in create group drawer which is yet to be refractored. Should we keep the autocomplete thing or get rid of it? The avatar drawer is yet to be refractored and might be handled in next PR. |
No autocomplete seems fine to me. Dealing with the avatar drawer in another PR is also fine. |
Summary
This PR mainly focus on changes for drawers in admin panel
References
#6215
Checklist
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.