Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Changes for admin panel drawers #6448

Merged
merged 28 commits into from
Jun 27, 2022
Merged

Changes for admin panel drawers #6448

merged 28 commits into from
Jun 27, 2022

Conversation

hanzlamateen
Copy link
Member

@hanzlamateen hanzlamateen commented Jun 17, 2022

Summary

This PR mainly focus on changes for drawers in admin panel

  • Fixed form validation in drawers and displayed errors
  • Changed create party dialog from modal to drawer
  • Changed style of autocomplete box
  • Added location, user, group, instance, party create, view, update to single location drawer

References

#6215

Checklist

  • If this PR is still a WIP, convert to a draft
  • ensure all checks pass
  • When this PR is ready, mark it as "Ready for review"
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewer

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Copy link
Member

@barankyle barankyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autofilling of text boxes in things like user name, group name, etc. is hard to read since the text color is white and the autofill background is near-white. On current dev, the autofill text color is black, which is much easier to see. You can test this by going to e.g. Create User, then clicking on the name field and selecting a value from one of the autofill options.

This appears to predate this issue, but if you could clean it up a bit that would be great: The avatar creation drawer has buttons and selectors that are very widely spaced and/or just wide. The 'Use URL/Upload Files' selector is on the far left, while the 'Avatar/Thumbnail' selectors are on the far right. I'm not sure if this would look better centered, or all on the left or right, but they should be together. The Upload button and Avatar Name field are also basically the full width of the drawer, which I don't think looks great - I think they'd look better as maybe 200px max wide and centered, or something around that (max-width: 100% if the drawer is less than 200px wide).

@hanzlamateen
Copy link
Member Author

Autofilling of text boxes in things like user name, group name, etc. is hard to read since the text color is white and the autofill background is near-white. On current dev, the autofill text color is black, which is much easier to see. You can test this by going to e.g. Create User, then clicking on the name field and selecting a value from one of the autofill options.

This appears to predate this issue, but if you could clean it up a bit that would be great: The avatar creation drawer has buttons and selectors that are very widely spaced and/or just wide. The 'Use URL/Upload Files' selector is on the far left, while the 'Avatar/Thumbnail' selectors are on the far right. I'm not sure if this would look better centered, or all on the left or right, but they should be together. The Upload button and Avatar Name field are also basically the full width of the drawer, which I don't think looks great - I think they'd look better as maybe 200px max wide and centered, or something around that (max-width: 100% if the drawer is less than 200px wide).

In my recent changes I removed autocomplete functionality from dialogs and as part this point in this PR, the autocomplete functionality is not there is create user drawer rahter its only in create group drawer which is yet to be refractored. Should we keep the autocomplete thing or get rid of it?

The avatar drawer is yet to be refractored and might be handled in next PR.

@barankyle
Copy link
Member

Autofilling of text boxes in things like user name, group name, etc. is hard to read since the text color is white and the autofill background is near-white. On current dev, the autofill text color is black, which is much easier to see. You can test this by going to e.g. Create User, then clicking on the name field and selecting a value from one of the autofill options.
This appears to predate this issue, but if you could clean it up a bit that would be great: The avatar creation drawer has buttons and selectors that are very widely spaced and/or just wide. The 'Use URL/Upload Files' selector is on the far left, while the 'Avatar/Thumbnail' selectors are on the far right. I'm not sure if this would look better centered, or all on the left or right, but they should be together. The Upload button and Avatar Name field are also basically the full width of the drawer, which I don't think looks great - I think they'd look better as maybe 200px max wide and centered, or something around that (max-width: 100% if the drawer is less than 200px wide).

In my recent changes I removed autocomplete functionality from dialogs and as part this point in this PR, the autocomplete functionality is not there is create user drawer rahter its only in create group drawer which is yet to be refractored. Should we keep the autocomplete thing or get rid of it?

The avatar drawer is yet to be refractored and might be handled in next PR.

No autocomplete seems fine to me. Dealing with the avatar drawer in another PR is also fine.

@hanzlamateen hanzlamateen marked this pull request as ready for review June 27, 2022 00:55
@hanzlamateen hanzlamateen merged commit 4f7545e into dev Jun 27, 2022
@hanzlamateen hanzlamateen deleted the admin-drawer-refactor branch June 27, 2022 17:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants