This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Fixed some bugs with user video. #6851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HexaField
approved these changes
Aug 31, 2022
In immersive mode, applying the non-displayed consumer video to the user avatar UI was often not playing. Changed this to creating a new video element from the consumer's track. Made self video displayed in immersive mode, per feedback about not having self video being disorienting. Moved application of display: auto/none to UserMediaWindow from UserMediaWindows, only applies to non-self windows. Renamed positionalAudio to positionalMedia (and all derivations of that). We are now using that setting to control both spatial audio and showing users' video above their avatar.
barankyle
force-pushed
the
immersive-self-video
branch
from
271b74a
to
f07d095
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In immersive mode, applying the non-displayed consumer video to the user avatar UI was often not playing.
Changed this to creating a new video element from the consumer's track.
Made self video displayed in immersive mode, per feedback about not having self video being disorienting.
Moved application of display: auto/none to UserMediaWindow from UserMediaWindows, only applies to non-self
windows.
Renamed positionalAudio to positionalMedia (and all derivations of that). We are now using that setting to control
both spatial audio and showing users' video above their avatar.
References
closes #insert number here
Checklist
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.