This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Fixed some issues with updating projects. #6857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a cache invalidation call to ProjectService.uploadProject. If new files are being fetched, whether from the deployment branch or as a reset from the main branch, all existing files caches are potentially invalid and should be cleared. Updated project download in downloadProjects.ts and githubapp-helper.ts to use storageProvider.getObject instead of .getCachedObject. This prevents project rebuilding from inadvertently using an old cached version of project files.
barankyle
requested review from
HexaField and
speigg
and removed request for
HexaField
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added a cache invalidation call to ProjectService.uploadProject. If new files are being fetched, whether
from the deployment branch or as a reset from the main branch, all existing files caches are potentially
invalid and should be cleared.
Updated project download in downloadProjects.ts and githubapp-helper.ts to use storageProvider.getObject
instead of .getCachedObject. This prevents project rebuilding from inadvertently using an old cached
version of project files.
References
closes #insert number here
Checklist
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.