This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Media system / components cleanup #6861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HexaField
suggested changes
Sep 5, 2022
…ponent behavior We were keeping entities w/ LocalTransformComponent parented under the parent entities
HexaField
suggested changes
Sep 9, 2022
| @@ -15,7 +15,7 @@ export const removeEntity = (entity: Entity, immediately = false, world = Engine | |||
| bitECS.removeEntity(world, entity) | |||
| } else { | |||
| removeAllComponents(entity, world) | |||
| addComponent(entity, EntityRemovedComponent, {}) | |||
| addComponent(entity, EntityRemovedComponent, null) | |||
There was a problem hiding this comment.
what's the reasoning for this? it will cause hasComponent checks to always return false
There was a problem hiding this comment.
whats the reason for doing this instead of true
There was a problem hiding this comment.
true takes up space, and isn't necessary; it's annoying that we even have to pass null, frankly, but it doesn't seem possible to have optional generic parameters that are also sometimes required
…on/XREngine into image-component-fixes
This reverts commit e1cd381.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
createMappedComponentdefineComponentReferences
closes #insert number here
Checklist
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.