This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Fixed some bugs with authentication settings. #6947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinkedIn key was doing incorrect function on change. Accessing some oauth fields on authSettings patch was throwing errors if that provider did not exist. Made access conditional. Changed source of default callback for an OAuth provider if one does not exist on existing callback.
This was
linked to
issues
Sep 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
LinkedIn key was doing incorrect function on change.
Accessing some oauth fields on authSettings patch was throwing errors if that provider did not exist. Made access conditional.
Changed source of default callback for an OAuth provider if one does not exist on existing callback.
References
closes #insert number here
Checklist
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.