Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Improved information about current builder. #7213

Merged
merged 4 commits into from
Nov 21, 2022
Merged

Conversation

barankyle
Copy link
Member

@barankyle barankyle commented Nov 12, 2022

Summary

getEngineVersion replaced by getBuilderInfo. It gets both the engine version and the current
commit.

Admin projects page now shows current builder commit. When opening the update/rebuild modal,
that modal attempts to set the builder tag to the current tag. Current tag is indicated
by '(Current)' in the Select.

Builder info now stored in ProjectService state.

Added EE version to Docker Hub tags.

References

closes #insert number here

Checklist

  • If this PR is still a WIP, convert to a draft
  • ensure all checks pass
  • When this PR is ready, mark it as "Ready for review"
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewer

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

@barankyle barankyle force-pushed the engine-info-improvements branch 2 times, most recently from ecae141 to bcd36d6 Compare November 12, 2022 02:18
@barankyle barankyle changed the title Improved admin project page. Improved information about current builder. Nov 12, 2022
@barankyle barankyle linked an issue Nov 12, 2022 that may be closed by this pull request
getEngineVersion replaced by getBuilderInfo. It gets both the engine version and the current
commit.

Admin projects page now shows current builder commit. When opening the update/rebuild modal,
that modal attempts to set the builder tag to the current tag. Current tag is indicated
by '(Current)' in the Select.

Builder info now stored in ProjectService state.

Added EE version to Docker hub image tags.
Copy link
Member

@HexaField HexaField left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting some errors when this is running on local dev, likely because the ECR and github stuff isn't configured by default. We should handle this gracefully. Otherwise looks good.

@barankyle
Copy link
Member Author

I'm getting some errors when this is running on local dev, likely because the ECR and github stuff isn't configured by default. We should handle this gracefully. Otherwise looks good.

What errors are you getting?

@HexaField
Copy link
Member

Screenshot from 2022-11-19 14-51-38

@HexaField HexaField merged commit dccbc4a into dev Nov 21, 2022
@HexaField HexaField deleted the engine-info-improvements branch November 21, 2022 23:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Current engine version should also show current commit
2 participants