This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Made all project branches and commits selectable #7342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of just getting the main and deployment-specific branches of a project, all branches are now retrieved and selectable. Pagination is done automatically, but it seems very unlikely that there will be so many branches that one might want to limit the number returned. Instead of getting just tagged commits and the latest one, the ten most recent commits are retrieved instead. The commit selector has been converted into a new custom Autocomplete that allows the user to enter a commit SHA manually if they want to get a commit older than those ten. Added a handler to project service to get individual commit. Updated all terminology from getting commit tags to just commits. Standardized displayed format of builder tags and commits to: Commit SHA -- Engine Version -- (Project Version) -- Date Pushed
barankyle
force-pushed
the
all-project-branches-selectable
branch
from
c790454
to
9f695f1
Compare
barankyle
requested review from
HexaField and
speigg
and removed request for
HexaField
HexaField
approved these changes
Dec 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A summary of changes being made in this PR
References
closes #insert number here
Checklist
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.