Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Refactor Avatar Movement Settings Into Hyperflux #7482

Merged
merged 2 commits into from
Jan 24, 2023
Merged

Refactor Avatar Movement Settings Into Hyperflux #7482

merged 2 commits into from
Jan 24, 2023

Conversation

HexaField
Copy link
Member

@HexaField HexaField commented Jan 20, 2023 •
edited
Loading

Summary

A summary of changes being made in this PR

References

closes #7262

Checklist

  • If this PR is still a WIP, convert to a draft
  • ensure all checks pass
  • When this PR is ready, mark it as "Ready for review"
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewer

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

@HexaField HexaField requested a review from speigg January 20, 2023 06:02
speigg
speigg suggested changes Jan 23, 2023
View reviewed changes
Copy link
Member

@speigg speigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's stick to our naming conventions. Normally our state modules end in *State.ts

@HexaField HexaField requested a review from speigg January 24, 2023 00:20
@HexaField HexaField merged commit 56ca364 into dev Jan 24, 2023
@HexaField HexaField deleted the refactor-avatar-movement-settings branch January 24, 2023 05:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@speigg speigg Awaiting requested review from speigg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Refactor] AvatarSettings should be hyperflux state
2 participants
@HexaField @speigg