This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Fixed some bugs with projects #7577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some projects were not showing up as pushable even if the user had GH access to them. This was caused by not being the owner of the project and the project being saved with the '.git' suffix on the URL; the check for whether a user had push access solely through GH was not checking for projects that had the '.git' suffix on them. Made allowedRepos add a copy of the URL with the '.git' suffix before doing the findAll on projects. Updated GITHUB_URL_REGEX to include a signature on the URL. This only really came up with projects that were present locally after a database reset, but it was breaking in that case. Since the signature is a capture group, everything that uses this regex now looks for data on index '2' from the exec instead of '1'. Fixed an inconsistency in project patching return data. Client-side listener now expects params to be the project data, instead of an object with a 'project' child. Fixed a bug with input text controlled by service state data. React's behavior is to set the selector to the end of an input if its value changes. This was causing some instances, like in project updating, to be very annoying to update through manual typing, since every character typed or deleted would jump to the end. Updated InputText to use a useEffect to reset the selector back to where it started.
barankyle
force-pushed
the
7530-admin-project-push
branch
from
1947d66
to
432d75d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some projects were not showing up as pushable even if the user had GH access to them. This was caused by not being the owner of the project and the project being saved with the '.git' suffix on the URL; the check for whether a user had push access solely through GH was not checking for projects that had the '.git' suffix on them. Made allowedRepos add a copy of the URL with the '.git' suffix before doing the findAll on projects.
Updated GITHUB_URL_REGEX to include a signature on the URL. This only really came up with projects that were present locally after a database reset, but it was breaking in that case. Since the signature is a capture group, everything that uses this regex now looks for data on index '2' from the exec instead of '1'.
Fixed an inconsistency in project patching return data. Client-side listener now expects params to be the project data, instead of an object with a 'project' child.
Fixed a bug with input text controlled by service state data. React's behavior is to set the selector to the end of an input if its value changes. This was causing some instances, like in project updating, to be very annoying to update through manual typing, since every character typed or deleted would jump to the end. Updated InputText to use a useEffect to reset the selector back to where it started.
A summary of changes being made in this PR
References
closes #insert number here
Checklist
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.