Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Fix vector and euler numeric input and make them reactive #7598

Merged
merged 23 commits into from
Feb 24, 2023

Conversation

AidanCaruso
Copy link
Member

@AidanCaruso AidanCaruso commented Feb 17, 2023

Summary

  • Adds a line to Vector3Input and EulerInput to set the value of a hookstate that the input value is later assigned to. This ensures numeric fields always register input.
  • Updates components in scale/position/rotate editor control functions so input fields react to changes.
  • Euler-input rotations are now only converted from quaternions when updated by editor control functions.

References

closes #7527 and #7526

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewer

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

@AidanCaruso AidanCaruso changed the title Fix vector and euler numeric input Fix vector and euler numeric input and make them reactive Feb 18, 2023
@AidanCaruso AidanCaruso linked an issue Feb 21, 2023 that may be closed by this pull request
@speigg speigg requested a review from dinomut1 February 21, 2023 22:58
@speigg
Copy link
Member

speigg commented Feb 23, 2023

last failing test here seems to be caused by a bug that is fixed in #7615

@dinomut1 dinomut1 merged commit a53b974 into dev Feb 24, 2023
@dinomut1 dinomut1 deleted the fix-vector-euler-editor-inputs branch February 24, 2023 21:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants