This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Fixed bugs with GH repo access #7600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Project update destination check was not comparing the correct URL string. Added 'hasWriteAccess' to github-repo-access model. This is needed to distinguish whether a user can push to that repo. github-repo-access-refresh now records this based on whether a user has admin, maintain, or write access to the repo. github-repo-access entries are now patched if they exist, to account for changes in write permission. Updated allowed project find to better express push access.
barankyle
force-pushed
the
repo-access-fixes
branch
from
1e07c5a
to
53f1efa
Compare
speigg
approved these changes
Feb 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Project update destination check was not comparing the correct URL string.
Added 'hasWriteAccess' to github-repo-access model. This is needed to distinguish whether a user can push to that repo. github-repo-access-refresh now records this based on whether a user has admin, maintain, or write access to the repo. github-repo-access entries are now patched if they exist, to account for changes in write permission.
Updated allowed project find to better express push access.
References
closes #insert number here
Checklist
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.