This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Refactor Engine World & Scene #7692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into eliminate-passing-currentWorld-around
…into eliminate-passing-currentWorld-around
…into eliminate-passing-currentWorld-around
…into eliminate-passing-currentWorld-around
This was referenced Mar 6, 2023
…into refactor-engine-world-scene
…into refactor-engine-world-scene
This was referenced Mar 7, 2023
Closed
speigg
approved these changes
Mar 7, 2023
|
Great cleanup. LGTM! |
HexaField
added a commit
that referenced
this pull request
Mar 8, 2023
* start to eliminate passing currentWorld around everywhere * more conversion * more removal * more removal * refactor engine world * remove old refs, move scene to engine * rename world to scene * bot state * fix model component * destroy engine * add back new api from #7425 * update getMutableState usage * ease eslint rules a bit * refactor execute and isEditor * move audio state out of engine * move public path to state * refactor network hostIds * Refactor Engine World & Scene (#7692) * start to eliminate passing currentWorld around everywhere * more conversion * more removal * more removal * refactor engine world * remove old refs, move scene to engine * rename world to scene * bot state * fix model component * destroy engine * Fix --------- Co-authored-by: Gheric Speiginer <gheric.speiginer@gmail.com> * Fixed some bugs with channels and messages (#7701) Data being sent to interested parties wasn't always the same as data returned to the sender from the creation/patch/deletion. Also needed to check that new messages didn't exist already. * add back new api from #7425 * update getMutableState usage * ease eslint rules a bit * refactor execute and isEditor * move audio state out of engine * move public path to state * refactor network hostIds * network schema in network state * move networks to network state * rename world refs to scene * fix tests * fix tsc * fix test --------- Co-authored-by: Gheric Speiginer <gheric.speiginer@gmail.com> Co-authored-by: Kyle Baran <kbaran@bitscoop.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A summary of changes being made in this PR
References
closes #7313
Checklist
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.