feat: reseed db before tests

[aditya-mitra]

Summary

Using an app setting testModeForceRefresh = true, the database can be seed in between tests.
Here, this setting has been used in user.test.ts

References

Closes #7726

Checklist

• If this PR is still a WIP, convert to a draft
• When this PR is ready, mark it as "Ready for review"
• ensure all checks pass
• Changes have been manually QA'd
• Changes reviewed by at least 2 approved reviewer

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

[HexaField]

replicating this locally, I get "message": "Table 'etherealengine.analytics' doesn't exist",

My guess is this doesn't work for multiple tests.

[HexaField]

rather than setting this manually, we can rely on appConfig.testEnabled, such that it is automatically applied every time createFeathersExpressApp is run

[aditya-mitra]

I tried to do this initially but encountered some problems. DB is also reseeded before tests (in npm run pretest) which requires process.exit(0) here. Using appConfig.testEnabled will have some problems.

[HexaField]

Ahh I see. Let's use the appConfig instead of feathers internal state. We can add a new configuration option with the desired functionality.

[aditya-mitra]

Added this change!

[aditya-mitra]

replicating this locally, I get "message": "Table 'etherealengine.analytics' doesn't exist",

My guess is this doesn't work for multiple tests.

@HexaField Can you please tell me the steps you followed to replicate this?

This is because I am testing this on a fresh database and not getting any error.
I also added this reseed in a few more tests in packages/server-core to check if it works across different test cases. It seemed to be working.

Can you please recheck it once?

[HexaField]

@HexaField Can you please tell me the steps you followed to replicate this?

Can you please recheck it once?

@aditya-mitra
I have copied your code exactly, and added

  if (appConfig.testEnabled) 
    app.set('testModeForceRefresh', true)

to createFeathersExpressApp in line 146 to ensure it reseeds before every test

This is the result:

[1678916225094] ERROR: Duplicate key name 'identity_provider_id'
    component: "server-core:sequelize"
    err: {
      "type": "DatabaseError",
      "message": "Duplicate key name 'identity_provider_id'",

[aditya-mitra]

@HexaField I found the error (it was a problem with a test) and have fixed it.

```ts
  if (appConfig.testEnabled) 
    app.set('testModeForceRefresh', true)

to createFeathersExpressApp in line 146 to ensure it reseeds before every test

I have also added the setting to reseed db in appConfig itself using above method. All tests will now reseed db before running their tests.

[HexaField]

@HexaField I found the error (it was a problem with a test) and have fixed it.

I have also added the setting to reseed db in appConfig itself using above method. All tests will now reseed db before running their tests.

Fantastic, let's replace the usage of testModeForceRefresh with appConfig.testEnabled directly and this should be good to go

[aditya-mitra]

Fantastic, let's replace the usage of testModeForceRefresh with appConfig.testEnabled directly and this should be good to go

Done with these changes!

[HexaField]

in server start.ts L27 and server-core seeder.tsx L63 we should add && !config.testEnabled to both conditionals

[cla-bot]

Thank you for your pull request and welcome to the Ethereal Engine developer community!

We require contributors to sign our Copyright Assignment Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign the agreement at https://forms.gle/15ENsSAJGKf2ozvB7

The agreement has not been signed by users: @aditya-mitra.

After signing the agreement, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR :)

[aditya-mitra]

@cla-bot check

[cla-bot]

Checking that all contributors to this PR are verified.