This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
tests(server-core): unit tests for location #7775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditya-mitra
changed the title
HexaField
suggested changes
Mar 25, 2023
| @@ -249,7 +249,7 @@ export class Location<T = LocationDataType> extends Service<T> { | |||
|
|
|||
| try { | |||
| // @ts-ignore | |||
| let { location_settings, ...locationData } = data | |||
| let { location_settings = {}, ...locationData } = data | |||
There was a problem hiding this comment.
locations should always be created with their associated settings, so i dont think this is necessary
There was a problem hiding this comment.
reverted this change!
aditya-mitra
force-pushed
the
tests/location
branch
from
d2665f8
to
3b0d4d0
Compare
HexaField
suggested changes
Apr 7, 2023
| }, | ||
| { where: { id: oldSettings.id }, transaction: t } | ||
| ) | ||
| if (location_settings) { |
HexaField
approved these changes
Apr 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Unit test for location service in server-core
References
Refs #5997
Checklist
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.