This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Instanced LOD System #7782
Merged
Instanced LOD System #7782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into instanced-lods
…into instanced-lods
…into instanced-lods
…into instanced-lods
…into instanced-lods
…into instanced-lods
…into instanced-lods
…into instanced-lods
*add serialization to LODComponent *add distance heuristic property to LODComponent
…into instanced-lods
HexaField
suggested changes
Apr 4, 2023
HexaField
suggested changes
Apr 5, 2023
fix apply lod transforms on level load allow lods with references to target model geometry
…into instanced-lods
add buffer and image hashing add lshIndex data structure
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BabylonJS has a more robust instanced LOD system that we will use as a basis. The difference between Babylon's instancing and the "thin" threejs instancing is detailed here:
https://discourse.threejs.org/t/lod-instancing/20524/2
We will implement the more robust instancing and LOD system using a LODComponent and LODSystem that work together to keep track of each instance's distance from the camera, and switch different instanced LODs on and off based on said distance. These components should be generated automatically when a model with instanced geometry is loaded into a scene.
The components should be configurable in the editor with some menu interface to add, remove, and edit LOD levels for every mesh in the scene, instanced or not. This UX should be embedded in the properties of the ModelComponent that contains the lod instances
We also need a GLTF extension for defining instanced LODs in Blender, modifying and saving LODs in engine, and successfully passing instanced LODs through Model Transforms without loss of information.
The same goes for a USD plugin that can define instanced LODs with equivalent functionality to the GLTF extension
This pull request closes #7785
closes #7786
closes #7787