Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Scene Data Refactor #7796

Merged
merged 8 commits into from
Mar 23, 2023
Merged

Scene Data Refactor #7796

merged 8 commits into from
Mar 23, 2023

Conversation

HexaField
Copy link
Member

@HexaField HexaField commented Mar 22, 2023 •
edited
Loading

Summary

  • Moves AppLoadingState and SceneState into the engine package
  • Removes multiple sources of truth for current loaded scene JSON
  • Refactors Scene object into SceneState
  • Refactors Stats Tool to use latest patterns regarding systems and state

References

closes #insert number here

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewer

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

@HexaField HexaField marked this pull request as ready for review March 23, 2023 10:35
@speigg
Copy link
Member

speigg commented Mar 23, 2023

LGTM

@speigg speigg added this pull request to the merge queue Mar 23, 2023
Merged via the queue into dev with commit c9edf91 Mar 23, 2023
@speigg speigg deleted the scene-data-refactor branch March 23, 2023 21:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@speigg speigg speigg approved these changes

@AidanCaruso AidanCaruso Awaiting requested review from AidanCaruso AidanCaruso is a code owner

Assignees
No one assigned
Labels
verified-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HexaField @speigg