Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

New System Defintions #7864

Merged
merged 55 commits into from
Apr 19, 2023
Merged

New System Defintions #7864

merged 55 commits into from
Apr 19, 2023

Conversation

HexaField
Copy link
Member

@HexaField HexaField commented Apr 5, 2023 •
edited
Loading

Summary

A summary of changes being made in this PR

References

closes #7363

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewer

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

@HexaField HexaField linked an issue Apr 5, 2023 that may be closed by this pull request
System reference counting for useSystems/initSystems #7800
Closed
HexaField and others added 26 commits April 5, 2023 11:36
@HexaField
Merge branch 'dev' of https://github.com/EtherealEngine/etherealengine …
6575eb3 
…into 7800-system-reference-counting-for-usesystemsinitsystems
@HexaField
Merge branch 'dev' of https://github.com/EtherealEngine/etherealengine …
5fe6bfe 
…into 7800-system-reference-counting-for-usesystemsinitsystems
@HexaField
continue with mvp api
35a122c
@HexaField
update a bunch of systems
fffcb91
@HexaField
more systems
0a50320
@HexaField
finish off systems and separate insertSystems from defineSystem
6ef9751
@HexaField
finalize pattern for insertion
ca09acd
@HexaField
Merge branch 'dev' of https://github.com/EtherealEngine/etherealengine …
412eaa5 
…into 7800-system-reference-counting-for-usesystemsinitsystems
@HexaField
refactor defintions and actions
b6b32a4
@HexaField
fixes
777538c
@HexaField
page sort of loads
b035400
@HexaField
Merge branch 'dev' of https://github.com/EtherealEngine/etherealengine …
7d4714a 
…into 7800-system-reference-counting-for-usesystemsinitsystems
@HexaField
more fixes
8f007d4
@HexaField
more
b012933
@speigg
Automate removeActionQueue cleanup
8aa3ef8
@speigg
Automate removeQuery cleanup
3158499
@speigg
Cleanup unnecessary query & action queue removals
5aeb7a2
@speigg
Fix errors
eb3096c
@HexaField
fix client modules not loading
edc8de8
@HexaField
remove sceneLoadingRegistry
a9a969b
@HexaField
remove sceneComponentRegistry
e68ad70
@HexaField
load fix
f0e0a72
@speigg
simplify defineSystem
aa2ccdd
@HexaField
Merge branch 'dev' of https://github.com/EtherealEngine/etherealengine …
ebe8143 
…into 7800-system-reference-counting-for-usesystemsinitsystems
@HexaField
merge
0a1fe08
@HexaField
editor loads
03f39e1
This was referenced Apr 18, 2023
Merged
Merged
@HexaField HexaField marked this pull request as ready for review April 18, 2023 05:00
@AidanCaruso
Copy link
Member

AidanCaruso commented Apr 18, 2023 •
edited
Loading

Just tested this out with bubble pop. Switching the systems in bubble pop to the new definitions and visiting the location url yields these errors that prevent the location from loading:
image

I've run dev-reinit and made sure my modules are up to date. Have I made a mistake in setup?

speigg
speigg suggested changes Apr 18, 2023
View reviewed changes
packages/client-core/i18n/en/common.json Show resolved Hide resolved
packages/client-core/i18n/en/editor.json Outdated Show resolved Hide resolved
packages/client-core/src/recording/RecordingService.ts Outdated Show resolved Hide resolved
packages/client-core/src/social/services/PartyService.ts Outdated Show resolved Hide resolved
packages/client-core/src/recording/RecordingService.ts Outdated Show resolved Hide resolved
packages/client-core/src/systems/LoadingUISystem.tsx Outdated Show resolved Hide resolved
packages/client-core/src/systems/ProjectUpdateSystem.tsx Outdated Show resolved Hide resolved
packages/client-core/src/world/ClientSystems.ts Outdated Show resolved Hide resolved
packages/client-core/src/world/DefaultLocationSystems.ts Outdated Show resolved Hide resolved
packages/client/src/pages/capture/capture.tsx Outdated Show resolved Hide resolved
@HexaField HexaField requested a review from speigg April 18, 2023 23:04
@HexaField HexaField merged commit 0402729 into dev Apr 19, 2023
@HexaField HexaField deleted the 7800-system-reference-counting-for-usesystemsinitsystems branch April 19, 2023 04:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@speigg speigg Awaiting requested review from speigg speigg is a code owner

Assignees
No one assigned
Labels
verified-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

System reference counting for useSystems/initSystems [RFC] System Execution Order
3 participants
@HexaField @AidanCaruso @speigg