Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

KTX2 Compression for Thumbnails, Envmaps #7901

Merged
merged 15 commits into from
May 4, 2023
Merged

KTX2 Compression for Thumbnails, Envmaps #7901

merged 15 commits into from
May 4, 2023

Conversation

AidanCaruso
Copy link
Member

Summary

Adds ktx2 compression to thumbnails and envmaps.

References

closes #insert number here

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewer

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

@AidanCaruso AidanCaruso linked an issue Apr 17, 2023 that may be closed by this pull request
Copy link
Member

@HexaField HexaField left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than changing all our logic to ktx2, we should add options to support multiple file types.

@AidanCaruso
Copy link
Member Author

Rather than changing all our logic to ktx2, we should add options to support multiple file types.

This makes sense for thumbnails, I'll add backwards compatibility there (and you can still load pngs as envmaps).

@AidanCaruso AidanCaruso requested a review from HexaField May 2, 2023 04:34
@AidanCaruso AidanCaruso marked this pull request as ready for review May 2, 2023 04:34
@speigg speigg enabled auto-merge May 4, 2023 00:51
@dinomut1 dinomut1 dismissed HexaField’s stale review May 4, 2023 22:22

changes implemented

@speigg speigg added this pull request to the merge queue May 4, 2023
Merged via the queue into dev with commit ca47706 May 4, 2023
@speigg speigg deleted the ktx2-compression branch May 4, 2023 22:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compress envmaps & thumbnails with KTX2
3 participants