Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

transformer fix #7978

Merged
merged 1 commit into from
May 11, 2023
Merged

transformer fix #7978

merged 1 commit into from
May 11, 2023

Conversation

SYBIOTE
Copy link
Member

@SYBIOTE SYBIOTE commented May 11, 2023

Summary

A summary of changes being made in this PR
fixes a bug in transform-model-helper, where string.replace does not replace more than the first character in the file name, fixed with adding g to end of regex expression

References

closes #insert number here

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewer

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

@dinomut1 dinomut1 self-requested a review May 11, 2023 21:29
Copy link
Member

@dinomut1 dinomut1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch

@dinomut1 dinomut1 added this pull request to the merge queue May 11, 2023
Merged via the queue into dev with commit 59ca772 May 11, 2023
@dinomut1 dinomut1 deleted the transformer-fix branch May 11, 2023 21:30
@SYBIOTE
Copy link
Member Author

SYBIOTE commented May 11, 2023

thanks cool

xr-dev-saurabh referenced this pull request in xr-dev-saurabh/etherealengine May 19, 2023
@SYBIOTE SYBIOTE changed the title trasnformer fix transformer fix Jun 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants