Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Fix peer create and destroy actions causing logging bugs #8000

Merged
merged 1 commit into from
May 22, 2023

Conversation

HexaField
Copy link
Member

@HexaField HexaField commented May 22, 2023

Summary

Actions should only ever contain data, not objects.

References

closes #insert number here

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewer

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

@HexaField HexaField changed the title remove objects from being passed to action Fix peer create and destroy actions causing logging bugs May 22, 2023
@barankyle barankyle added this pull request to the merge queue May 22, 2023
Merged via the queue into dev with commit c7e0cce May 22, 2023
@barankyle barankyle deleted the fix-peer-logging branch May 22, 2023 23:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants