This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Failed connection fix #8033
Merged
Failed connection fix #8033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a connection fails, it will sometimes provision a new server. This was only checking if the current connection's 'connected' status was true, but not whether the 'connecting' status was true. On some long-loading scenes, the initial connection was failing right as a second provision was starting, and was leading to two connections being made concurrently, which would cause problems - the second connection would not make any dataProducers/dataConsumers, leaving the user with no networking despite being connected. Fixed a few bugs that were causing type errors.
barankyle
force-pushed
the
failed-connection-fix
branch
from
b6564a5
to
dd445a5
Compare
HexaField
approved these changes
May 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A summary of changes being made in this PR
References
closes #insert number here
Checklist
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.