This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Cleaned up dependency installation #8048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barankyle
force-pushed
the
dependency-cleanup
branch
4 times, most recently
from
838d0c8
to
6387194
Compare
barankyle
force-pushed
the
dependency-cleanup
branch
from
6387194
to
f4f38de
Compare
HexaField
suggested changes
Jun 5, 2023
barankyle
force-pushed
the
dependency-cleanup
branch
from
f4f38de
to
362aee2
Compare
HexaField
approved these changes
Jun 5, 2023
barankyle
force-pushed
the
dependency-cleanup
branch
from
362aee2
to
a60beec
Compare
Made production npm installs only install prod dependencies through --production flag. Removed some unused dependencies and moved some dependency definitions if they were only used in specific packages. Made lerna a devDependency, which works fine in production builds. Ran depcheck on all packages to identify and fix most extraneous or unspecified dependencies. Removed a number of top-level npm scripts that just called a script. Replaced any calls to those npm scripts with the appropriate command.
barankyle
force-pushed
the
dependency-cleanup
branch
from
a60beec
to
0107f4e
Compare
hanzlamateen
approved these changes
Jun 6, 2023
There was a problem hiding this comment.
Looks good. Also updated control center to update scripts that were removed from package.json
https://github.com/EtherealEngine/etherealengine-control-center/pull/99/files
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Made production npm installs only install prod dependencies through --production flag.
Removed some unused dependencies and moved some dependency definitions if they were only used in specific packages.
Made lerna a devDependency, which works fine in production builds.
Ran depcheck on all packages to identify and fix most extraneous or unspecified dependencies.
References
closes #insert number here
Checklist
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.