Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Threejs 153 #8066

Merged
merged 7 commits into from
Jul 19, 2023
Merged

Threejs 153 #8066

merged 7 commits into from
Jul 19, 2023

Conversation

HexaField
Copy link
Member

Summary

A summary of changes being made in this PR

References

closes #insert number here

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewer

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

@HexaField HexaField requested a review from dinomut1 June 8, 2023 22:10
dinomut1
dinomut1 approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@dinomut1 dinomut1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am able to load scenes with geometry, particles and avatars without a hitch. No issues detected, seems ready for merge

@HexaField HexaField marked this pull request as ready for review July 19, 2023 01:50
@HexaField HexaField added this pull request to the merge queue Jul 19, 2023
@HexaField HexaField removed this pull request from the merge queue due to a manual request Jul 19, 2023
@HexaField HexaField merged commit 8e66d23 into dev Jul 19, 2023
7 checks passed
@HexaField HexaField deleted the threejs-153 branch July 19, 2023 01:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dinomut1 dinomut1 dinomut1 approved these changes

Assignees
No one assigned
Labels
verified-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HexaField @dinomut1