-
-
Notifications
You must be signed in to change notification settings - Fork 0
feat(projects): move project download button to file browser panel #8100
Conversation
Let's move the button next to the refresh button |
@HexaField The previous download button was only for downloading projects. Since the refresh button belongs to the |
Yeah we want this in the file browser UI itself |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To protect against abuse, let's allow the downloader to only allow downloads from /projects/*
paths, such that any other path (including /projects
) are disallowed. This should be done in the service, and return an Error otherwise.
…into feat/admin-projects-download-button
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great from the admin panel, but when I click the download button in the file browser in the studio, it downloads as undefined.zip
Fixed this! |
39e80a4
to
f1f4324
Compare
…into feat/admin-projects-download-button
Last thing, let's hide the button for non-project directories. (nested directories in a project are fine) |
Sure. Implementing this! |
…realEngine/etherealengine into feat/admin-projects-download-button
Summary
References
closes #7903
Checklist
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.