-
-
Notifications
You must be signed in to change notification settings - Fork 0
Changes for location services to use schema, knex & feathers 5 #8103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've noticed that selecting a location type when creating/editing a location in /admin/locations does not work ATM; no options are populating the selector, so it cannot be used. Since I see this on dev as well, it seems this PR didn't break it, but please fix it since it fits with everything else this PR is doing.
I also noticed that if a user goes to a location they are not authorized for, the Not Authorized notification is not shown. From the logs it looks like that action it getting dispatched, but it's not being picked up, or something. This can be tested by making a private location, then opening a new browser profile and trying to go to that location as a guest.
I have fixed the location type not appearing in location drawer issue. Though for Not Authorized notification, I am not sure why its not appearing. I looked into the code and its been called properly. It seems like
|
Will look into this |
Summary
This PR Covers following services migration to feathers 5:
References
#7645, closes #8284
Checklist
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.