This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
8134 post processing settings are not reactive #8262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
the other are working accordingly as well |
…into 8134-post-processing-settings-are-not-reactive
HexaField
suggested changes
Jul 12, 2023
packages/editor/src/components/properties/PostProcessingSettingsEditor.tsx
Outdated
Show resolved
Hide resolved
…s://github.com/EtherealEngine/etherealengine into 8134-post-processing-settings-are-not-reactive
HexaField
suggested changes
Jul 12, 2023
packages/engine/src/renderer/functions/configureEffectComposer.ts
Outdated
Show resolved
Hide resolved
HexaField
approved these changes
Jul 13, 2023
HexaField
suggested changes
Jul 13, 2023
packages/engine/src/renderer/functions/configureEffectComposer.ts
Outdated
Show resolved
Hide resolved
HexaField
approved these changes
Jul 13, 2023
|
oh this was resolved? im closing the issue then |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
the effects were being sourced from the global state -> PostProcessingeffectsstate, but we were not setting the state anywhere, therefore its always the default
i replaced the source with the PostProcessingComponent instead, it works now
References
closes #insert number here
Checklist
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.