Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Add Envmap Bake Target Property #8269

Merged
merged 3 commits into from
Jul 13, 2023
Merged

Add Envmap Bake Target Property #8269

merged 3 commits into from
Jul 13, 2023

Conversation

HexaField
Copy link
Member

Summary

A summary of changes being made in this PR

References

closes #insert number here

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewer

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

@HexaField HexaField changed the title add envmap bake target node and refactor envmap reactor Add Envmap Bake Target Property Jul 12, 2023
@AidanCaruso
Copy link
Member

AidanCaruso commented Jul 12, 2023

Being able to select envmapbake components is great! But I'll note that in the envmap reactor you removed the Default case functionality where, when no texture/bake is assigned, an envmapbake component that the envmap component is inside the box of is automatically assigned. This means that all scenes that were sampling bpcem envmaps this way are broken and must be updated, including the apartment and my demo in the test suite.
image

@HexaField
Copy link
Member Author

Being able to select envmapbake components is great! But I'll note that in the envmap reactor you removed the Default case functionality where, when no texture/bake is assigned, an envmapbake component that the envmap component is inside the box of is automatically assigned. This means that all scenes that were sampling bpcem envmaps this way are broken and must be updated, including the apartment and my demo in the test suite. image

I updated the development test suite, forgot about the apartment!

@HexaField HexaField enabled auto-merge July 13, 2023 23:03
@HexaField HexaField disabled auto-merge July 13, 2023 23:11
@HexaField HexaField merged commit c29f45e into dev Jul 13, 2023
@HexaField HexaField deleted the envmap-bake-target-node branch July 13, 2023 23:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants