This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Serialized uploading of scenes to storage provider #8275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barankyle
force-pushed
the
asset-upload-serialize
branch
from
1a5c022
to
0576c6b
Compare
Certain projects with multiple scenes that had very large files, like uvols, could crash the API server when installed fresh. Even though each scene's media files get uploaded sequentially, the scenes were being run in parallel, leading to simultaneous uploads of those large files. Made uploadLocalProjectToProvider process each file sequentially to avoid this.
barankyle
force-pushed
the
asset-upload-serialize
branch
from
0576c6b
to
c415633
Compare
HexaField
approved these changes
Jul 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Certain projects with multiple scenes that had very large files, like uvols, could crash the API server when installed fresh. Even though each scene's media files get uploaded sequentially, the scenes were being run in parallel, leading to simultaneous uploads of those large files. Made uploadLocalProjectToProvider process each file sequentially to avoid this.
References
closes #insert number here
Checklist
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.