Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

feat(editor): component window (scenePrefabs refactored) #8278

Merged
merged 19 commits into from
Jul 20, 2023
Merged

feat(editor): component window (scenePrefabs refactored) #8278

merged 19 commits into from
Jul 20, 2023

Conversation

aditya-mitra
Copy link
Collaborator

@aditya-mitra aditya-mitra commented Jul 13, 2023 •
edited
Loading

Summary

  • refactor the usage of scenePrefabs
  • remove Engine.instance.scenePrefabRegistry
  • handle drop behavior of the elements into scene, hierarchy tree and property panels

References

closes #8151

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewer

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

@aditya-mitra aditya-mitra marked this pull request as draft July 13, 2023 15:15
@aditya-mitra aditya-mitra changed the title feat: new component window feat(editor): component window (scenePrefabs refactored) Jul 17, 2023
@aditya-mitra aditya-mitra marked this pull request as ready for review July 17, 2023 18:38
@HexaField HexaField self-requested a review July 19, 2023 05:30
HexaField
HexaField suggested changes Jul 19, 2023
View reviewed changes
Copy link
Member

@HexaField HexaField left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just need to fix the studio tests

@HexaField HexaField self-requested a review July 20, 2023 04:48
@HexaField HexaField merged commit 05aa766 into dev Jul 20, 2023
8 checks passed
@HexaField HexaField deleted the feat/component-window-prefab-remove branch July 20, 2023 04:58
@speigg
Copy link
Member

speigg commented Jul 20, 2023

This PR seems to have broken volumetric playback

@aditya-mitra aditya-mitra mentioned this pull request Jul 27, 2023
Closed
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@HexaField HexaField HexaField approved these changes

Assignees
No one assigned
Labels
verified-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unify prefab window with component drop down
3 participants
@aditya-mitra @speigg @HexaField